Design comparison
SolutionDesign
Solution retrospective
height: 100vh; on main div to center a item , is this a good practice
Community feedback
- @fernandolapazPosted over 1 year ago
Hi, regarding your comment:
- You got it right, although it would be even better to use
min-height: 100vh
since usingheight
causes the page to cut off in viewports with a small height (such as mobile landscape orientation).
And let me add this:
- Consider using a good semantic structure with headings, paragraphs, etc. instead of wrapping each element with
<div>
.
- The image is not decorative and the
alt
attribute should have at least a short description.
I hope it’s useful : )
Regards,
Marked as helpful0@TANJIRWEBDEVPosted over 1 year ago@fernandolapaz thank you for your kind response , i will look into it
1 - You got it right, although it would be even better to use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord