Design comparison
Community feedback
- @SamadeenPosted over 2 years ago
Hey Alberta!! Cheers 🥂 on completing this challenge.. .
Here are my suggestions..
- You should use <main class="comp"> instead of <div class="comp">.
- Go down orderly when you are using the headings h1 down to h2 down to h3 and so on.
- You should likely use the font recommended in your style.md file
- You can also reduce the font-size of your header
This should fix most of your accessibility issues
. Regardless you did amazing... hope you find this useful... Happy coding!!!
Marked as helpful1@Ogbo0810Posted over 2 years ago@Samadeen Thanks for the feedback. I actually used the recommended font family but I'm yet to find out why it hasn't reflected yet. Also, thanks for drawing my attention to the headings and semantics.
0 - @anaschaoukiPosted over 2 years ago
Looks nice, though your font should be the one from the style guide other than that good job!
0@Ogbo0810Posted over 2 years ago@anaschaouki Thanks so much for the feedback. I included the font style in my CSS file but it hasn't reflected. I'm yet to review and find out why
0@anaschaoukiPosted over 2 years ago@Ogbo0810 Try replacing the imported font with this
@import url("https://fonts.googleapis.com/css2?family=Outfit:wght@400;700&display=swap");
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord