Design comparison
Solution retrospective
𝑭𝒆𝒆𝒅𝒃𝒂𝒄𝒌𝒔 𝒂𝒓𝒆 𝒘𝒆𝒍𝒄𝒐𝒎𝒆 🚀
Community feedback
- @HassiaiPosted over 1 year ago
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
0@madhukar-30Posted over 1 year ago@Hassiai well I use relative units .Only in this solution I have used px. Thanks for the feedback
0 - @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
QR iMAGE ALT TEXT 📸:
- The QR Code Component involves scanning the QR code, the image is not a decoration, so it must have an
alt
attribute which should explain the purpose of theimage
.
- The
alt
withQR code
is not even explaining for what the QR image need to be used.
- So update the
alt
with meaningful text which explains likeQR code to frontendmentor.io
Example
<img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
0@madhukar-30Posted over 1 year ago@0xAbdulKhalid I will correct it.. thanks for reviewing my code
0@0xabdulkhaliqPosted over 1 year ago@madhukar-30 Glad you found it helpful ! 🤠
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord