qr code component using flexbox

Community feedback

• 

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  Hey JSninjawizard!! Cheers 🥂 on completing this challenge.. . Here are my suggestions 1.You should use <main class="container"> instead of <div class="container">.

  2. Go down orderly when you are using the headings h1 down to h2 down to h3 and so on.

  3. You can also increase and change the color of your headings and paragraph to get a look alike from the design

  . Regardless you did amazing.. Happy coding!!!

  Marked as helpful

  0
• 

  Joseph Maramba Weyao•195

  @mamba-dev-KEPosted over 2 years ago

  Hey, impressive implementation here. I had a look at your code and have some recommendations:

  • To improve your html structure, consider adding a main tag to hold all the content within body.
  • As for the width of the card you can control it using a set-width that is not equal to 100% of the container so that the card does not touch the sides of the screen and a max-width on the card to ensure it does not grow past a set max-width value.

  I used these approaches in my QR code solution, you can have a look under my profile.

  Marked as helpful

  0

  ---

  

  JSninjawizard•10

  @JSninjawizardPosted over 2 years ago

  @mamba-dev-KE thank you so much for your reply

  you have done this challenge with react right? i cant seem to find html structure in the github, within the body there is only one id " <div id="root"></div>" could you please show me?

  1

  

  Joseph Maramba Weyao•195

  @mamba-dev-KEPosted over 2 years ago

  @JSninjawizard Hey. Yes. I did it with React. Everything is a component that has its own styles. Check out the QRCode component and its styles under src/components/QRCode and the global stylesheet under src/styles.scss....

  Are you familiar with React? If not, I'd be more than happy to create a CodePen explaining the concepts in an easier format for you.

  0

  

  JSninjawizard•10

  @JSninjawizardPosted over 2 years ago

  @mamba-dev-KE hey :) i know the core concepts of react im about to start learning it. its ok you dont have to do CodePen for this i got your remarks and i will implement them!

  1