Design comparison
Solution retrospective
I'd like feedback on how i could have better designed the project. Thank you.
Community feedback
- @HassiaiPosted over 1 year ago
Replace <div class="wrapper"> with the main tag, <h2> with <h1> to main the content accessible. click here for more on web-accessibility and semantic html
Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.
Add the alt attribute
alt=" "
to the img tag and give it a value to fix the error issue. The value of the alt attribute is the description of the image. For decorative images like icons, there is no need to give it an alt value, for more on alt attribute Click here.To center .container on the page using flexbox, replace the height in .wrapper with min-height: 100vh.
for a responsive content replace the width in .container with
max-width
.Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
0@ZiyyahhPosted over 1 year agoThank you for the feedback it was very helpful @Hassiai
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord