QR code component using Flexbox

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Alberto Ledesma•370

  @ledesmxPosted over 1 year ago

  Hello Abdul Khalid,

  Thank you for your valuable feedback, this is helpful for me.

  0
• 

  Josh•1,110

  @josh76543210Posted over 1 year ago

  Hi @AlbertoLed,

  Great job on your solution!

  Here are some recommendations for you (skip to the bottom if you just want the code 😉):

  First of all, I would remove the absolute positioning of the attribution and also the fixed height of the body. These will cause problems for users viewing your page on smaller screens such as on a mobile phone.

  Next, add a min-heightof 100vh to the body. This is to replace the height we removed earlier. Also, add a flex-direction of column to position the attribution back underneath the container.

  Lastly, I suggest adding a margin-top of auto to the container and the attribution. This will make sure everything is centered nicely.

  Code to remove:

  body {
    height: 100vh;
  }
  
  .attribution {
    position: absolute;
    bottom: 30px;
  }
  

  Code to add:

  body {
    flex-direction: column;
    min-height: 100vh;
  }
  
  .container {
    margin-top: auto
  }
  
  .attribution {
    margin-top: auto
  }
  

  I hope this is helpful. Happy Coding!

  Marked as helpful

  0

  ---

  

  Alberto Ledesma•370

  @ledesmxPosted over 1 year ago

  Hi Josh, Thanks for taking the time to give me feedback, I appreciate it.

  0