Skip to content
Submitted over 1 year ago

QR code component using Flexbox

Kevin H.•150
@kevinx9000
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Is there a box shadow around the white box?? I continually struggled determining if there was one at all cause there seems to be something faintly there, but I couldn't figure out the correct configuration to match it.

How do you recommend adding the attribution? I thought it would be simple to add it after I finished the challenge, but then it threw everything off. I had to create an additional main section to wrap the flexbox of the white box, just so I could have a footer outside of it, but even then it took some positioning to try to get it somewhere.

Community feedback

  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    HEADINGS ⚠️:

    • This solution consists incorrect usage of <h2> so it can cause severe accessibility errors due to incorrect usage of level-three headings <h2>
    • Every site must want only one h1 element identifying and describing the main content of the page.
    • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
    • In this solution there's <h2> element which is this <h2>Improve your...</h2>, you can preferably use <h1> instead of <h2>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely
    • So we want to add a level-one heading to improve accessibility
    • Example: <h1>Improve your front-end skills by building projects</h1>
    • If you have any questions or need further clarification, and feel free to reach out to me.
    • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

    QR iMAGE ALT TEXT 📸:

    • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute.
    • The alt attribute should explain the purpose of the image.
    • E.g. alt="QR code to frontendmentor.io"
    <img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
    0
    Kevin H.•150
    @kevinx9000Posted over 1 year ago

    @0xAbdulKhalid Thanks for the feedback! I updated my code with the heading tag and alt tag suggestions.

    0
    Kevin H.•150
    @kevinx9000Posted about 1 year ago

    Revisited and updated code

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord