Design comparison
Solution retrospective
I welcome all feedback on my project, whether it's positive or constructive criticism. Your comments and suggestions are greatly appreciated as I strive to continuously improve. Please feel free to rate my project and leave any thoughts or ideas you have. Thank you in advance for taking the time to review it.
Community feedback
- @MelvinAguilarPosted almost 2 years ago
Hello π. Congratulation on successfully completing your first challenge π ! !
I am not an expert but I have some recommendations regarding your code that I believe will be of great interest to you.
HTML π·οΈ:
- The <br> tag is often used to create line breaks, but it doesn't convey any semantic meaning. When a screen-reader reads the text, it will break the flow of reading at the line break tag, which can be confusing for users. More information here.
- Since this component involves scanning the QR code, the image is not a decoration, so it must have an
alt
attribute. Thealt
attribute should explain its purpose. e.g.QR code to frontendmentor.io
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord