Skip to content
Submitted about 1 year ago

QR code component using Flexbox

acorriaz•10
@acorriaz
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Feedback welcome

English isn't my first language, so I might not be super fluent. But I will try to explain as best as I can

  • I wanted to ask if I should always include width and height in <img> element but if I write width and height how to do that without changing image ratio
  • How to name class I'm reading that BEM is a good way. Does it have an alternative that I should know?
  • And last question, should I always use CSS Reset for reduce browser inconsistencies?

Community feedback

  • Purdanoski•30
    @PurdanoskiPosted about 1 year ago

    Nice job! -You can use width OR height on img tags, that way you won't change the ratio, don't use them both. But simply you can always set in resets for the image to have width: 100% and display: block. And yes you should use resets. -About the naming of classes there is no specific rule, just make sure they are descriptive so you don't wonder around looking for what is it set for.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord