Skip to content
Submitted about 2 years ago

QR Code Component Using Flexbox

Keithā€¢70
@Grill3dCheese
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hello! Just curious on the structure of my HTML. I did a div for the container and one div for the card which contains all of the elements within the card (image, h1 and paragraph tags) - is this the right way to structure the card? Or should the image have been in one div and the h1 and paragraph tags in another div? Overall, it worked in the end, but I wasn't sure if there are better practices to follow. Thank you!

Community feedback

  • derCalle.exeā€¢210
    @pascal-prfstPosted about 2 years ago

    Maybe you can put the container div into <main> tag and the attribution tag into a <footer> tag. Everything else looks solid.

    Happy coding

    1
    Keithā€¢70
    @Grill3dCheesePosted about 2 years ago

    @pascal-prfst Awesome! Thank you so much for the feedback. I'll be sure to do that on my next project! Happy coding! :)

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord