Submitted 10 months ago
QR Code Component using Flexbox
@vincentwilliamrodriguez
Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I'm glad to have accomplished this challenge efficiently.
What challenges did you encounter, and how did you overcome them?There was not much challenge in doing this.
What specific areas of your project would you like help with?- What are better ways to place space around the text elements without nesting flexboxes?
- How can the custom properties' names be improved according to conventions?
- It says in style-guide.md that the paragraph font size is 15px, yet this seems to be off compared to the design images. Is this correct?
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @vincentwilliamrodriguez!
Your solution looks great!
I have a suggestion for improvement:
- For semantic reasons, use
mainto wrap the main content instead of adiv.
š This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful1 - For semantic reasons, use
- @BlackpachamamePosted 10 months ago
Greetings! you have done a great job š
š Some accessibility and semantics recommendations for your HTML
- To improve the semantics of your HTML, you can change your
<div class="main">to a<main class="main">and the<div class="attribution">to a<footer class="attribution"> - On this same page you go to the DESIGN COMPARISON part and click on the red button that says Generate new screenshot
Marked as helpful1 - To improve the semantics of your HTML, you can change your
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord