QR code component using Flex Box CSS

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi Chermann, congratulations on your solution!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  Replace the <h3> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.

  Clean your code by removing some unnecessary divs, most of the content can stand alone without a div. Use div only for blocks that need a special alignment or the content needs a special positioning.

  Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.

  Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

  ✌️ I hope this helps you and happy coding!

  2

  ---

  

  Chermann KING•430

  @Chermann-KINGPosted about 2 years ago

  Thank you @correlucas for this feedback and all these suggestions to improve my code. I will take note of it.

  1

  

  Chermann KING•430

  @Chermann-KINGPosted about 2 years ago

  @correlucas I just cleaned up the html and css code, could you tell me what you think this time! Thanks for your feedback :)

  0

  

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  @Chermann-KING Hey, this is nice, then say me if worked and if was useful for you. Have a nice day bro

  0

  

  Chermann KING•430

  @Chermann-KINGPosted about 2 years ago

  @correlucas Yes I found that the recommendations were not complicated and it is much more sober to write code this way.

  0