QR code component using flex box

Community feedback

• 

  Fatlind Shehu•2,230

  @fatlindshehuPosted over 2 years ago

  Hi @Theuz1nh0,

  I think you did a great approach to the challenge, the component is perfectly designed and very responsive, for the future, I would suggest:

  • Avoid using px rem and em altogether, it's a good practice to choose one ( I would go for the rem cause its base font size doesn't change its the root).
  • Try giving a margin to the component on small screen sizes, in order for the browser to not overflow them.
  • Use a pre-processor & a naming style convention ( BEM & SASS for my preference)

  Overall u did great, keep up the good work!

  Marked as helpful

  1

  ---

  

  Mateus Moura Domingos•140

  @Theuz1nh0Posted over 2 years ago

  @fatlindshehu Thank you very much for the feedback, I will follow your tips and try to improve more and more. I haven't studied or seen anything about CSS preprocessors yet, but I intend to see it as soon as possible, thanks.

  1