Skip to content
Submitted over 2 years ago

QR Code Component Using Flex and CSS Grid

Aman Zaveri•50
@Aman-Zaveri
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Feedback would be greatly appreciated. More specifically, feedback on the usage of my div tags. Is it necessary to have 2 div tags in this program, or is one sufficient. While using one div tag, would it be necessary to use the displays in the body tag instead? Thanks in advance :)

Community feedback

  • Rio Cantre•9,690
    @RioCantrePosted over 2 years ago

    Hello there! Great work with this one. Regarding the solution you submitted, I think you should know the following notes…

    • Instead of div, alternatively wrap the whole content with semantic tags, for HTML structures, refer it with this one Semantics. Like this part <div class="container"> could be wrap with main tag and this <span class="footer"> with footer tag

    Other than that...

    • The HTML structure is organized and readable
    • Great job in using Sass for styling
    • The project is responsive and utilized the details based on original design

    Above all, The project is awesome! Keep it up!

    Marked as helpful
    1
    Aman Zaveri•50
    @Aman-ZaveriPosted over 2 years ago

    @RioCantre Thanks so much for the feedback! I tried experimenting with semantic tags in my Testimonial Grid Section Challenge, but I wasn't sure if I had used them wisely or in the correct form. Thanks so much though :)

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord