QR code component using CSS grid and HTML

Community feedback

• 

  Daniel 🛸•44,270

  @danielmrz-devPosted 10 months ago

  Hello @revanthv999!

  Your solution looks excelent!

  I have just one suggestion:

  • In order to make your HTML code more semantic, use <h1> for the main title instead of <h2>. Most people think it's just about the size and weight of the text, but it's not.

  📌 The <h1> to <h6> tags are used to define HTML headings.

  📌 <h1> defines the most important heading.

  📌 <h6> defines the least important heading.

  📌 Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  This change has little or not effect at all on the project, but it makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, you did a great job!

  Marked as helpful

  0
• 

  raya•2,870

  @rayaattaPosted 10 months ago

  Hello revanthv999👋, congratulations on completing your first FED challenge 🎉

  I have some suggestions you might find useful.

  I noticed that you used h2 .since it is the only heading in the document you should replace it with <h1>.

  Here's a quick guide on how to use them:

  The <h1> to <h6> tags are used to define HTML headings. <h1> defines the most important heading. <h6> defines the least important heading. Only use one <h1> per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with <h1>, then use <h2>, and so on. You can then style them in you css.

  Unlike what most people think, it's not just about the size and weight of the text It is about maintaining a clear and consistent hierarchy through out the document

  2 The qr code's alt attribute should not just have info that it is a qr code rather it should state where the qr leads i.e alt="qr code leading to frontendmentor.io

  3 It is a bad practice to set both the height and width of an image. The most recommended practice is giving it a max-width.Usually

  img {
  display:block;
  max-width:100%;
  }
  

  This would be a more responsive approach

  I hope this helps 🙃

  Otherwise your solution is neat👍

  Happy coding ✌️

  Marked as helpful

  0