QR code component using CSS Grid and Flexbox

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 6 months ago

  Hello there!

  Congrats on completing the challenge! ✅

  Your solution looks excellent!

  I have just one suggestion:

  • Use only <main> to wrap the main content instead of <main> and <article>.

  📌 The tag <article> would make more sense if the card was part of a bigger website (in certainly would in real world), but here it is all we have on the screen.

  Unless you have a specific reason to use both, there's no need, considering that you can achieve the same result with only one. It also makes it easier positioning the elements inside.

  This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  1

  ---

  

  Azian•50

  @dwangsstPosted 6 months ago

  @danielmrz-dev thanks for your supportive feedback, I've adjusted my solution based on that.

  Now, my solution is clean from the accessibility report and HTML report

  1
• 

  P

  Koda👹•3,830

  @kodan96Posted 6 months ago

  hi there 👋

  You should avoid hard-coded values (pixels) most of the time. When you use these values you give up responsibility (or you make it harder for yourself at least)..

  Typically you will increase the font-size property with @media queries. If you have hard-coded values all over your CSS, you need to modify every element's font-size. On the other hand, if you use rem-s all you need to do is changing the font-size in your CSS :root selector and all your elements will have a new size based on that value.

  I usually use em for padding and margin for text-based elements, since their margin usually based on their font-size, and again, when you change the font-size in :root these values will scale up as well without you touching them, making your job easier and your page maintainable.

  Hope this helps! 🙏

  Good luck and happy coding!

  Marked as helpful

  1

  ---

  

  Azian•50

  @dwangsstPosted 6 months ago

  @kodan96 thanks for your supportive feedback, I've adjusted my solution based on that.

  1