Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component using CSS flexbox

@Valac01

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello everyone, this is my first challenge. If you guys have any feedback I would appreciate it.

Community feedback

PhoenixDev22 16,950

@PhoenixDev22

Posted

Hi Barish Barla,

Congratulation on completing this frontend mentor challenge. Your solution looks great. I have some suggestions regarding your solution:

  • You should use <main> for the card and <footer> for the attribution. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
  • In my opinion, the image is an important content. The alternate text is needed on this image. The alternate text should indicate where the Qr code navigate the user : like QR code to frontend mentor not describes the image.

Aside these, great job on this one. Hopefully this feedback helps.

Marked as helpful

0

@Valac01

Posted

@PhoenixDev22 Thanks a lot for the feedback. I'll update the code following your suggestions.

0
PhoenixDev22 16,950

@PhoenixDev22

Posted

@Valac01

Glad to help. Happy coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord