PhoenixDev22• 16,950
@PhoenixDev22
Posted
Hi Barish Barla,
Congratulation on completing this frontend mentor challenge. Your solution looks great. I have some suggestions regarding your solution:
- You should use
<main>
for the card and<footer>
for the attribution. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
- In my opinion, the image is an important content. The alternate text is needed on this image. The alternate text should indicate where the Qr code navigate the user : like
QR code to frontend mentor
not describes the image.
Aside these, great job on this one. Hopefully this feedback helps.
Marked as helpful
0
Barish Barla• 40
@Valac01
Posted
@PhoenixDev22 Thanks a lot for the feedback. I'll update the code following your suggestions.
0
PhoenixDev22• 16,950
@PhoenixDev22
Posted
@Valac01
Glad to help. Happy coding!
0