QR code component using CSS Flexbox

Community feedback

• 

  Mayank Arora•430

  @mayankdrvrPosted about 1 year ago

  Congratulations @NovaMakeIt for completing this challenge. Your design matches the solution very well.

  Here are a few observations-

  1. Below 323px width of screen, the text and card gets partially hidden, the text does not wrap and the image does not resize. Maybe, you can make it more responsive by setting the maximum width of card to be upto 100% of width of its parent container(body). See if using this CSS property in image styling can make the image more responsive- max-width: 100%;. Use min-height: 100vh; in body styling for body to take up all the space of the viewport.
  2. Avoid using <div> element in html file and use semantic html elements throughout the code for better web accessibility.
  3. Using noopener and noreferer in <a> elements is a good security practice with cross browser compatibility.
  4. Try to use the Block Element Modifier(BEM) naming method as a good practice of naming classes for referencing html elements in the css file.
  5. Use relative dimensions like rem wherever possible.

  Modified html body(i have left BEM naming for your practice)-

    <div class="card">
      <img src="./images/image-qr-code.png" alt="A QR code" class="qr-code" />
      <h2 class="heading">Improve your front-end skills by building projects</h2>
      <p class="description">Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
    </div>
  

  Modified css file-

  * {
      margin: 0;
      padding: 0;
      font-size: 15px;
      box-sizing: border-box;
  }
  
  body {
      font-family: "Outfit", sans-serif;
      background-color: hsl(212, 45%, 89%);
      display: flex;
      flex-direction: column;
      justify-content: center;
      align-items: center;
      min-height: 100vh;
  }
  
  .card {
      width: 320px;
      height: 497px;
      border-radius: 20px;
      background-color: hsl(0, 0%, 100%);
      box-shadow: 5px 5px 5px rgba(90, 89, 89, 0.2);
      max-width: 100%;
  
  }
  
  .qr-code {
      padding: 16px 16px 0px 16px;
      max-width: 100%;
      border-radius: 0.625rem;
  }
  
  
  .heading {
  
      margin: 10px 34px 0 34px;
      font-size: 20px;
      text-align: center;
      font-weight: 700;
      color: hsl(218, 44%, 22%);
  }
  
  .description {
  
      margin: 20px 30px;
      font-size: 15px;
      text-align: center;
      font-weight: 400;
      color: hsl(220, 15%, 55%);
  }
  
  .attribution {
  
      text-align: center;
      margin-top: 20px;
  }
  
  .attribution a {
      color: hsl(228, 45%, 44%);
  }
  

  Awesome solution and keep it up.

  Marked as helpful

  0

  ---

  

  NOVA•60

  @NovaMakeItPosted about 1 year ago

  Thanks @mayankdrvr for your valuable advice !

  0