
Design comparison
Community feedback
- @Tamir-NahmiasPosted about 2 months ago
overall , your website looks great! very similar to the original design we were given . nonetheless ,in your next project, consider adding semantic HTML elemetns inside the body tag such as "main" and "footer" (for the card content , and the "Attribution" section correspondigly), they are excellent for accesibilty and for SEO ranking. also, for non semantic elements such as div, try to add roles . the layout of the screen is just fantastic, and corresponing very well to diffrent sizes , altough I didn't see min size for mobile phones. your code is very well written , you succeded your task with minimum div elements and brought fantastic results! (btw, I've learnt a thing or two from your desgin , thanks!)
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord