QR code component using css flex, html

Community feedback

• 

  Panji•2,090

  @pperdanaPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have some additional recommendations for your code that I think you'll find interesting and valuable.

  📌 Add <main> tag as semantic HTML in code

  • The <main> tag is a semantic HTML element that is used to define the main content of a web page.

  • The <main> tag should be used to wrap the primary content of a web page, such as the main article, section, or body of text.

  for example code:

  <main>
    <div class='container'>
      <h1>Article Title</h1>
      <p>Article content goes here...</p>
      .......................
    </div>
  </main>
  

  In the example above, the <main> tag is used to wrap the <div> tag, which contains the primary content of the web page. This tells both human readers and search engines that the content inside the <main> tag is the most important and relevant content on the page.

  I hope you found this helpful!

  Happy coding🤖

  Marked as helpful

  1

  ---

  

  Felista5•20

  @Felista5Posted over 1 year ago

  @Panji200 Noted. Thanks

  0
• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  • If you use max-width instead of width, the card will be responsive

  #container {
    /* width: 300px; */
    max-width: 300px;
  }
  

  • You've defined font-family and font-weight and then you've defined the same values in texts again. I recommend you try to avoid repetition.

  #first {
    /* font-family: "Outfit", sans-serif; */
  }
  

  #second {
    /* font-weight: 400; */
    /* font-family: "Outfit", sans-serif; */
  }
  

  • Finally, you'd better remove width from the text. After updating it, you won't have view like in screenshot and it will look better

  p {
    /* font-size: 15px; */
    /* margin: auto; */
    /* width: 90%; */
  }
  

  Hope I am helpful. :)

  Marked as helpful

  1

  ---

  

  Felista5•20

  @Felista5Posted over 1 year ago

  @ecemgo Thank you very much, I have taken note of them.

  1

  

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  @Felista5 happy to help! :)

  1
• 

  jordanBuilder•60

  @jordanBuilderPosted over 1 year ago

  hey ,what's up ?.. have you done it by yourself ..?

  1

  ---

  

  Felista5•20

  @Felista5Posted over 1 year ago

  @jordanBuilder I'm learning more about it by building projects. Thank you.

  0