Skip to content
Submitted over 1 year ago

QR code component using CSS custom properties and flex box

Wessel Konstantinov•350
@WesselKonstantinov
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

This is my solution to the QR code component challenge. I decided to include a CSS reset to set up some default styles. I looked into Andy Bell's one for this. This reset contains styles referring to tags that I did not use in this challenge. For example:

/* Inherit fonts for inputs and buttons */
input,
button,
textarea,
select {
  font: inherit;
}

Should I leave out the default styles that are not relevant to the styling of the QR code component or is it better to always include the entire CSS reset?

I am looking forward to your feedback and suggestions!

Community feedback

  • Shivraj K•400
    @Shivraj-K09Posted over 1 year ago
    • It is not necessary to include the entire CSS reset if you are only using a small portion of it. In your case, you could remove the styles that are not relevant to your QR code component.
    • However, keeping the entire CSS reset may be beneficial in case you decide to use those styles elsewhere in your project. It is a matter of personal preference and project requirements.
    • It's great to see that you are paying attention to CSS best practices and leveraging a CSS reset to ensure consistent styles across different browsers. Keep up the good work! and Happy Coding 😉
    Marked as helpful
    2
    Wessel Konstantinov•350
    @WesselKonstantinovPosted over 1 year ago

    @Shivraj-K09 Hi Shivraj-K09, thank you very much for the feedback! I will keep this in mind for future projects!

    0
  • Basit Korai•350
    @basitkoraiPosted over 1 year ago

    Congratulations on your project completion. You have done a good job.

    I think including the whole CSS reset will not make much difference, because this one is a pretty simple and straightforward project. So I guess omitting the unnecessary CSS reset will make your code look simple and easy to read. That's it. ✌️

    Marked as helpful
    1
    Wessel Konstantinov•350
    @WesselKonstantinovPosted over 1 year ago

    @basit-flash Thank you for your feedback!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord