QR code component using HTML and CSS

Community feedback

• 

  P

  Trần Thành Danh•1,500

  @TranDanh1122Posted 3 months ago

  that good go start something, but we can improve it:

  1. h1 element is "improve front end...", that MUST NOT hidden, beucause SEO rule.
  2. when you have a line of text, use span, not p
  3. font need to linked before link stylesheet file
  4. you need html reset * {margin 0 padding 0 box-sizing border box}, that will help you have full control spacing
  5. try to use %, rem, vw, not px, because very hard to change when you need responsive text or people change size of text in their phone (you can try it on your real phone, and see why im recommend use rem)
  6. need :root to declare all color as variable, dont use color code all around you code, very hard to manage in real life project

  Hope that helpful!!!!!

  Marked as helpful

  1

  ---

  

  J.•10

  @J-Dot555Posted 3 months ago

  @TranDanh1122 Thank you for the helpful tips.

  0