@DanijelAdrinek
Posted
Hey Marlo, I liked your project and decided to take a look at it for a bit, and I found some things I think you can improve on.
-
For starters, the card size is the same on the phone and on desktop, there is no need for it to be in %, the width should be in px, and same as on the design, while the height should depend on the height of the content
-
You should remove the margin on container, they dont do anything because the card is already centered by the body
-
The figure tag is unnecessary because this image doesnt have a caption below it
-
The text class should be called text-container, because its not referring to the element holding the text, but its parent
I hope these tips help you become a better web developer, and help you on your journey towards getting this amazing job, and if you want to learn more mind-blowing tips on solving this challenge, I did actually make a blog post that shows how to properly do that, so if you are interested in learning more, here is the link for that:
https://dev.to/danijeladrinek/frontend-mentor-qr-code-challenge-4g9h
if you have any more questions feel free to let me know, have an amazing day, and happy coding :)
Marked as helpful
