Design comparison
Community feedback
- @Agnik7Posted over 1 year ago
Hi,
Congratulations on completing this challenge!!🎉🎉🎉
I have some suggestions that might pique your interests.
-
Replace the h2 tag with an h1 tag. It is always preferred to start with
h1
and gradually move your way down the heading levels. -
Instead of defining the width of the card, define the max-width. By defining only the max-width, you are specifying the maximum width the card can take up, but its width can reduce depending on the screen size. However, by defining width, you are making the width of the card constant. Use max-width for better responsiveness.
-
Try using relative units like rem and em instead of absolute unit like px. The px values are constant irrespective of screen sizes, and may result in overflow in some screens. The rem and em depend on the screen size, thereby catering to better responsiveness. For more info, click here.
Hope this feedback helps you to improve and grow. Have a nice day!!!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord