QR Code Component using CSS.

Community feedback

• 

  Cristian Melo•50

  @cristianmeeloPosted about 1 year ago

  Hello Samarth! You did a great job! Congratulations on finishing the challenge. I would also like to supplement your reading about semantic html, take a look at when to use tags like h1-h6, p, main. This will make your code more readable.

  Feel free to see/comment in my solution too.

  Marked as helpful

  1

  ---

  

  Samarth Bhardwaj•50

  @Samarth-5109Posted about 1 year ago

  @cristianmeelo, thanks for the feedback. Will keep in mind to make use of semantics from next challenge.

  0
• 

  gfunk77•1,200

  @gfunk77Posted about 1 year ago

  Hi Samarth, this looks really good. Congrats. I would suggest the following:

  On the container, you can remove flex-direction, width, and align-content. Width is 100% by default and you don't need to make the container a column flex in this case since your goal is just to center here.

  Similarly, on the .card, you don't need flex at all because these will stack on top of each other any way. On the img just do display: block; max-width: 100%; If the rest is just text-aligned, it should work.

  You will have far less css and it will be in proportion to the size of the project. Well done. Congrats.

  Marked as helpful

  1

  ---

  

  Samarth Bhardwaj•50

  @Samarth-5109Posted about 1 year ago

  @gfunk77, thanks for the feedback. Will again look at this challenge and apply your suggestions and get back to you. Can I submit it again? after optimizations.

  0

  

  gfunk77•1,200

  @gfunk77Posted about 1 year ago

  @Samarth-5109

  Sure, you can submit as many times you want

  0