Design comparison
SolutionDesign
Solution retrospective
Frontend Mentor 001 : My First Project
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing your first challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- This solution generates accessibility error reports due to
non-semantic
markup
- So fix it by replacing the
<div class="container">
with semantic element<main>
and<div class="attribution">
with semantic element<footer>
to improve accessibility and organization of your page.
- Since this component involves scanning the QR code, the image is not a decoration, so it must have values in
alt
attribute. Thealt
attribute should explain its purpose. e.g.alt="QR code to frontendmentor.io"
I hope you find it helpful ! 😄 Above all, the solution you submitted is great
Happy coding!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord