QR code component using CSS

Community feedback

• 

  Svitlana Suslenkova•5,360

  @SvitlanaSuslenkovaPosted 2 months ago

  I see you tried to align project with grid. You need to add to body min-height: 100vh. It's height now is not a full screen height, but content's height

  Marked as helpful

  1

  ---

  

  Cyber-dave-official•40

  @Cyber-dave-officialPosted about 2 months ago

  Ok thanks for your support I really appreciate it

  0
• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted about 2 months ago

  HTML:

  • <main> holds all of the main content on a page. As a card would likely not be the only component on a page, I would wrap the card content in a <div class="card"> inside of <main>.

  • The image has meaning, so it must have proper alt text. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  • Headings should always be in order, so you never start with a <h3>. I would make it a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

  • Do not use <br> to force text onto a new line. The text should flow naturally, and all styling, including space between elements, should be done in the CSS.

  • .attribution should be a <footer>, and you should use <p> for the text inside.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • Remember to specify a fallback font:font-family: 'Outfit',sans-serif;

  • I recommend adding 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

  • Remove the margin on the body. As Svitlana mentions, you need to add min-height: 100svh on the body, as it is only as tall as its content by default.

  • Remove the margin on the card, it is not needed, since you're centering the card using Grid.

  • Remove display: inline-block on the card, it is not needed.

  • Remove all widths and heights in px. We rarely want to give a component a fixed size, as we want it to grow and shrink according to the screen size.

  • We do want to limit the width of the card, so it doesn't get too wide on larger screens. To solve this issue, give the card a max-width of around 20rem.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • 400px is not a valid value for the font-weight property, you would have to change that to font-weight: 400.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • On the image, add display: block and max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container. Remove margin-top, that space should come from the padding on the card itself.

  • As the design doesn't change, there is no need for any media queries. When you do need them, they should be in rem or em, not px.

  Marked as helpful

  0

  ---

  

  Cyber-dave-official•40

  @Cyber-dave-officialPosted about 2 months ago

  @Islandstone89 thanks for your corrections I really appreciate it. Your corrections are really helping me improve as a young developer and I appreciate it, I really do

  1