Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code Component using basic HTML, CSS, and flexbox

@hpsetti

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


  1. I would like to know if my project is in-line with the best practices (E.g. CSS class naming convention, file structure, readme, etc)

  2. I would like to know if any features could be added, I have few in my mind like generating custom QR code whenever a user enters their own website, but I'm open to any suggestions :).

Community feedback

Tobias 100

@ToHX

Posted

Hi there 👋

Some issues I saw

  • your CSS class naming could be improved with BEM
  • Your img has no alt Attribute
  • You have a h3 but no h1
  • Font size always in rem

Marked as helpful

2

Account Deleted

@ToHX you mean , using rem is better practice for fonts

0
Kacper Kwinta 1,405

@kacperkwinta

Posted

Hi!

Some tips for fixing errors in your solution report:

  • add alt="" tag to image
  • create <main> tag and wrap all other elements into this

Marked as helpful

0

@cloudyay

Posted

Hi Harish

The solution looks great. There is something I would like to know. How were you able to create the white box of almost the same dimensions? Is there a way to figure out what should be the width and height size?

Thanks, Megha

0

@hpsetti

Posted

@cloudyay

Hey Megha,

I use a tool called "preview" wherein I just highlight the component that I want to measure. I think it's a macOS exclusive app, but I'm sure Windows has better apps to do the same :)

Harish

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord