QR code component usign HTML and CSS

Community feedback

• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! Juan Good Job on challenge

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Add Main tag after body <main class="container"></main>

  -> you have added too much padding around the qr-img

  -> Learn more on accessibility issues

  If this comment helps you then pls mark it as helpful!

  Have a good day and keep coding 👍!

  Marked as helpful

  0

  ---

  

  Juan Herrera•130

  @Juan13052001Posted almost 3 years ago

  @Crazimonk Thank you for your comments and I will take them into account in order to improve my skills.

  0
• 

  Fury•945

  @ashiqfuryPosted almost 3 years ago

  Great work. Welcome to the frontend mentor, I cant believe this is your first project.

  • Dont use height in the main div container.
  • Use relative values like % for your img and div instead of absolute values.
  • You can use flexbox to code your more clean and responsive like:

  body {
        min-height: 100vh;
        display: flex;
        align-items: center;
        justify-content: center;
  }
  .container {
        margin: 0;
  }
  
  

  I hope my suggestions will work for your future projects. Thank you.

  Marked as helpful

  0

  ---

  

  Juan Herrera•130

  @Juan13052001Posted almost 3 years ago

  @ashiqfury Thank you for your comments and I will take them into account in order to improve my skills.

  0
• 

  Hexer•3,660

  @EmmanuelHexerPosted almost 3 years ago

  Great work overall man. Keep it up

  0

  ---

  

  Juan Herrera•130

  @Juan13052001Posted almost 3 years ago

  @Phalcin Thanks for your comment

  0