Design comparison
Solution retrospective
Any comment is accepted in order to improve my design, unfortunately I still do not understand well the flexbox and grid, the question is: what would you recommend me to use, now, what framework do you recommend? And about the position, how would you use it in this situation?
Community feedback
- @NaveenGumastePosted over 2 years ago
Hay ! Juan Good Job on challenge
These below mentioned tricks will help you remove any Accessibility Issues
-> Add Main tag after body
<main class="container"></main>
-> you have added too much padding around the
qr-img
-> Learn more on accessibility issues
If this comment helps you then pls mark it as helpful!
Have a good day and keep coding 👍!
Marked as helpful0@Juan13052001Posted over 2 years ago@Crazimonk Thank you for your comments and I will take them into account in order to improve my skills.
0 - @ashiqfuryPosted over 2 years ago
Great work. Welcome to the frontend mentor, I cant believe this is your first project.
- Dont use
height
in the maindiv
container. - Use relative values like % for your
img
anddiv
instead of absolute values. - You can use
flexbox
to code your more clean and responsive like:
body { min-height: 100vh; display: flex; align-items: center; justify-content: center; } .container { margin: 0; }
I hope my suggestions will work for your future projects. Thank you.
Marked as helpful0@Juan13052001Posted over 2 years ago@ashiqfury Thank you for your comments and I will take them into account in order to improve my skills.
0 - Dont use
- @EmmanuelHexerPosted over 2 years ago
Great work overall man. Keep it up
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord