QR code component

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello Ahmed Zaki, congratulations for your first solution! 👋 Welcome to the Frontend Mentor Coding Community!

  Great start and great first solution! You’ve done really good work here putting everything together, I’ve some suggestions you can consider applying to your code:

  1.Give your component the proper vertical alignment min-height: 100vh; body display 100% of the viewport height (this makes the container align to the height size thats now 100% of the screen height) size and display: flex e flex-direction: column to align the child element (the container).

  See the code fixing that below:

  body {
      min-height: 100vh;
      font-family: 'Outfit', sans-serif;
      background-color: hsl(212, 45%, 89%);
      display: flex;
      align-items: center;
      justify-content: center;
      flex-direction: column;
  }
  

  2.For future projects think about using relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices.

  Something that can be a time saver for you is to use a CSS RESET to remove all default settings for margins, making the images easier to work, see the article below where you can copy and paste this css code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/

  ✌️ I hope this helps you and happy coding!

  1
• 

  Ahmed Zaki•60

  @Ahmed-Zaki20Posted about 2 years ago

  It's my first project to submit. I had little difficulties but I'll work hard to improve my front-end skills ^^

  0