QR Code Component

Community feedback

• 

  Louis-Cyrus Sanjabi•90

  @Louis-CyrusPosted 8 months ago

  The solution differ a little bit from the design, use a padding to space the qr code. In the html you should use a section who encompass all the code

  Marked as helpful

  0
• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 8 months ago

  HTML:

  • Move the CSS to the stylesheet.

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap the card in a <main>.

  • Give the card a class instead of an ID. Here is a good article explaining when and how to use the id attribute.

  • The image has meaning, so it must have proper alt text. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(frontendmentor.io).

  • Never have text in divs alone. "Improve your" is a heading, and it doesn't need to be wrapped in a <div>.

  • .attribution should be a <footer>, and you should use <p> for the text inside.

  CSS:

  • Be sure to add the font-family on the body.

  • Add gap: 2rem on body, to create some space between the <main> and the <footer>.

  • Including a CSS Reset at the top is good practice.

  • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

  • On the body, change height to min-height - this way, the content will not get cut off if it grows beneath the viewport.

  • Remove all widths and heights.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

  • On the image, add display: block and max-width: 100% - the max-width prevents it from overflowing its container.

  • To create the space between the image and the edge of the card, set padding on all 4 sides of the card.

  0