QR code component

Community feedback

• 

  Erik Aakre•230

  @eaakrePosted over 1 year ago

  I had to look through your Github. The github-pages for this site brings me to the folder and a 404 error, but I found that this is your live link for the qr-component:

  https://izkurten.github.io/Frontend-Mentor-QR-Challenge/qr-code-component-main/index.html

  Maybe update the 'Live Link' on here to this url instead?

  Looking at the actual page though, it looks great! Well done!

  Marked as helpful

  1

  ---

  

  Christopher Tonkov•20

  @izkurtenPosted over 1 year ago

  @eaakre Hello. Yes, apparently.. After the problem with the picture, I tried to manually remove the files, because I figured out I had added them to the repository, but instead of adding images/QR-image.jpeg, I removed the folder and added just the image. Therefore, when the source for the <img> is /images/QR-image.jpeg of course it won't open it. So tried to fix it by removing the files and just adding the whole folder with all the info. I will look into figuring out Github more an maybe then continue with the challenges. Thank you for taking the time to give me some feedback, Erik!

  0

  

  Christopher Tonkov•20

  @izkurtenPosted over 1 year ago

  @izkurten I think it's fine now when I used the URL you proposed. Thanks, dude!

  0
• 

  Erik Aakre•230

  @eaakrePosted over 1 year ago

  When I download the starter files for each project here, I notice there is an extra folder that contains another folder with all the starting files. I only keep that last folder that includes the images, designs, index.html, etc...otherwise when you put those files on Github, that extra folder will be included. Then, the site won't actually show up because there isn't an 'index.html' file in the main folder.

  Also, it looks like you are manually uploading each file onto Github. Here is a link on how to connect your Github to VS Code. If you have a different editor, you can probably do something similar. It will save you some time

  https://www.youtube.com/watch?v=shP-3p-2m6g

  1
• 

  Christopher Tonkov•20

  @izkurtenPosted over 1 year ago

  Also, when I look at the github URL, it's in the same format as the assignment. It's just that the QR doesn't load and shows the alt="" info. While here, it's totally upside down with the text on the top. why..

  0