QR code Component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
  • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
  • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="container"> element with the proper semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0

  ---

  

  Julius Mcbraham Paapa-Boateng Somuah•230

  @khophisnowPosted over 1 year ago

  @0xAbdulKhalid Well noted. I will include them in my next challenge. Thank you for your help

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  @khophisnow Glad you found it helpful ! 🤠

  0

  

  Julius Mcbraham Paapa-Boateng Somuah•230

  @khophisnowPosted over 1 year ago

  @0xAbdulKhalid thanks for your suggestions

  0
• 

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  Congratulations on completing the challenge🎉! That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. You need to add Semantic HTML tags

  The HTML structure should be semantically correct. The current structure doesn't provide any semantic information about the content. A better approach would be to use appropriate HTML tags such as <header>, <main>, <section>, <article>, etc. to define the sections of the page.<main> tag to indicate that it represents the main content of the page. You can wrap up .attribution class within <footer> as a part of semantics.Wrapping the .attribution class within a <footer> element is a great way to improve the semantics and structure of your code. here is the code that u need to add to include semantic tags in ur page

  <main>
  <div class="container">
  <div class="card">
  <div class="card-title">
  <img src="assets/img/image-qr-code.png" alt="qr-code">
  </div>
  <div class="card-body">
  <h3>Improve your front-end skills by building projects</h3>
  <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
  </div>
  </div>
  </div>
  </main> 
  <footer>
  <div class="attribution">
  Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. 
  Coded by <a href="https://github.com/khophisnow">Julius Mcbraham Paapa-Boateng Somuah</a>.
  </div>
  </footer>
  

  0

  ---

  

  Julius Mcbraham Paapa-Boateng Somuah•230

  @khophisnowPosted over 1 year ago

  @Kamlesh0007 Thank you for your suggestions it will be of much help. I will see to include that in my next challenge

  0