QR code component

Community feedback

• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted about 2 months ago

  Hi Ali, good job!

  A few suggestions:

  HTML:

  • Remove role="main", that is already implied on the <main> element.

  • Remove <div class="container">, it is not needed. You only need a <main> with a <div> inside holding the card content.

  • The alt text should be written naturally, without using - between the words. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  • Headings should always be in order, so you never start with a <h3>. I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • I recommend adding 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

  • Move the styles on .container to body, and change height to min-height - this way, the content will not get cut off if it grows beneath the viewport.

  • max-width on the card should be in rem. Change it to 20rem, which equals 320px.

  • On the image, add display: block and change width to max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

  Marked as helpful

  0

  ---

  

  Ali Mohamed•60

  @AliMohamed35Posted about 2 months ago

  @Islandstone89

  thank you for the helpful tips, will apply them to the next project <3

  1
• 

  Alexander Gusev•170

  @WaRaGiSmYnIcKnAmEPosted about 2 months ago

  Good job! You have fixed a design flaw with the text and your solution looks better than the task!

  Marked as helpful

  0

  ---

  

  Ali Mohamed•60

  @AliMohamed35Posted about 2 months ago

  @WaRaGiSmYnIcKnAmE Thank you mate <3

  0