QR Code Component

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace<div class="qr-container">with the main tag, <h6> with <h1> and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

  To center .qr-container on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  To center .qr-container on the page using flexbox:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  To center .qr-container on the page using grid:
  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  Use the colors and font-family that were given in the styleguide.md found in the zip folder you downloaded.

  Replace the height value in .qr-container with a padding value for all the sides, this will prevent the content from overflowing on smaller screen sizes. Give the img a max-width of 100% and border-radius value the rest are not needed.

  There is no need to give h1 and p a width value, height value and position relative. Give h1 the same font-size as p.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  2