QR code component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component, and additionally we want to add fixed position for <footer> element to place it in bottom of the page

  body {
      min-height: 100vh;
      display: grid;
      place-items: center;
  }
  
  footer {
     position: fixed;
     bottom: 1em;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .containter-fluid {
    padding-top: 8%;
  }
  footer {
    padding-top: 100px;
    padding-bottom: 5px;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  Toufiq005•150

  @Toufiq005Posted over 1 year ago

  your solution is actually good but I think you should start using css framework like tailwind css or bootstrap v5 instead of writing raw css this will increase your productivity.

  Marked as helpful

  0