QR code component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Daniel, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • Centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid and is superfluous with flex
  • add min-heigth: 100vh to .container class because Flexbox aligns child items to the size of the parent container
  • instead of using px try to use relative units of measurement -> read here

  Overall you did well :)

  Hope this help and happy coding!

  Marked as helpful

  1

  ---

  

  Daniel Jimenez•20

  @danieljimenezcrPosted over 2 years ago

  @denielden Thank you for your feedback, i have already make the changes, could you plase check if everything is ok?

  Regards :)

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  @danieljimenezcr You are welcome! Now it's much better :) Keep it up

  0
• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted over 2 years ago

  Hello Daniel Jimenez ! Congo 👏 on completing this challenge

  Let's look at some of your issues, shall we:

  • Add Main tag after body <main class="container"></main>

  • Use the color give in style-guide .md for the p tag

  happy Coding😀

  Marked as helpful

  1

  ---

  

  Daniel Jimenez•20

  @danieljimenezcrPosted over 2 years ago

  @Crazimonk Thanks for the feedback!! I will do that

  Regards :D

  1
• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Good job with this challenge danieljimenezcr. Keep up the good work

  Your solution looks great however to fix your accessibility issue wrap all your content within <main> tags.

  I hope this helps

  Cheers, Happy coding 👍

  Marked as helpful

  1

  ---

  

  Daniel Jimenez•20

  @danieljimenezcrPosted over 2 years ago

  @TheCoderGuru Thanks! i will do that

  1
• 

  Hamdi Mohamud•100

  @hamdi2008Posted over 2 years ago

  Nice work. I will just add that it needs Mobile Responsive Design.

  Marked as helpful

  1

  ---

  

  Daniel Jimenez•20

  @danieljimenezcrPosted over 2 years ago

  @hamdi2008 Thanks for the feedback i will work on that!

  0