Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

i tried

imwade32• 10

@imwade32

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Jason 👾• 160

@super-gill

Posted

I think i can help you a little bit, your image directory in the img tag is expecting the image to be in an images sub directory but its at the root and should be changed to src="image-qr-code.png"

The font of the p tag should be the same as the title I think

Theres nothing paticularily wrong with how you sized the containers but you might want to consider using flexbox ( https://css-tricks.com/snippets/css/a-guide-to-flexbox/ ) or grid ( https://css-tricks.com/snippets/css/complete-guide-grid/ ) for this kind of project as they can give you lots of flexibility and extra tools

edit, i added a couple of extra things there is no title section, this is html tag that defines the text that appears in the browsers tab at the top, its not essential for the page to work but should be present.

You should put the main content of the body in <main></main> tags, this highlights the important part of your website and influences how they appear in searches (not relevant to this particular project but a good habit to have)

The footer text should be in a footer tag, if you want to know more about semantic html read this: https://www.w3schools.com/html/html5_semantic_elements.asp im still learning these things too!

hope that's helpful!

Marked as helpful

0

imwade32• 10

@imwade32

Posted

@super-gill Super helpful and I really appreciate it!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord