QR Code Component - Svelte

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi Ryan, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • remove all margin from card
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after add min-heigth: 100vh to body because Flexbox aligns to the size of the parent container

  Overall you did well :)

  Hope this help and happy coding!

  Marked as helpful

  1

  ---

  

  Ryan Barnes•250

  @barnesPosted almost 3 years ago

  @denielden Thanks for the feedback, I've deployed those changes. Flexbox centering worked great!

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  @barnes You are welcome! I would really appreciate if you mark my comment as helpful if it helped you, thank you very much :)

  0
• 

  optimusprime202•1,200

  @optimusprime202Posted almost 3 years ago

  Hey @barnes, Superb work!

  0