QR code component Solution

Community feedback

• 

  P

  Steven Stroud•11,910

  @StroudyPosted about 2 months ago

  Amazing job with this! You’re making fantastic progress. Here are some small tweaks that might take your solution to the next level…

  • You dont need to wrap your image in a <div> tag, It is unnecessary,

          <div class="img">
            <img src="images/image-qr-code.png" alt="qr-code" />
          </div>
  

  • While px is useful for precise, fixed sizing, such as border-width, border-radius, inline-padding, and <img> sizes, it has limitations. Pixels don't scale well with user settings or adapt to different devices, which can negatively impact accessibility and responsiveness. For example, using px for font sizes can make text harder to read on some screens, Check this article why font-size must NEVER be in pixels. In contrast, relative units like rem and adjust based on the user’s preferences and device settings, making your design more flexible and accessible. Use px where exact sizing is needed, but prefer relative units for scalable layouts. If you want a deeper explanation watch this video by Kevin Powell CSS em and rem explained. Another great resource I found useful is this px to rem converter based on the default font-size of 16 pixel.

  • Using rem or em units in @media queries is better than px because they are relative units that adapt to user settings, like their preferred font size. This makes your design more responsive and accessible, ensuring it looks good on different devices and respects user preferences.

  • Line height is usually unitless to scale proportionally with the font size, keeping text readable across different devices. Best practice is to use a unitless value like 1.5 for flexibility. Avoid using fixed units like px or %, as they don't adapt well to changes in font size or layout.

  You’re doing fantastic! I hope these tips help you as you continue your coding journey. Stay curious and keep experimenting—every challenge is an opportunity to learn. Have fun, and keep coding with confidence! 🌟

  Marked as helpful

  0

  ---

  

  Tuhin-jr•250

  @Tuhin-jrPosted about 2 months ago

  Hi @Stroudy Thank you so much for taking your valuable time to leave such a nice informative comment.

  1

  

  P

  Steven Stroud•11,910

  @StroudyPosted about 2 months ago

  Hey @Tuhin-jr, No problem, I hope it was helpful and guides you on your path to learning front end, You got this! 💪

  0

  

  Tuhin-jr•250

  @Tuhin-jrPosted about 2 months ago

  Thank you @Stroudy. I look forward to more guides like this from you in the future.

  1