QR code component solution with HTML and CSS

Community feedback

• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 6 months ago

  HTML:

  • I would have a <div class="card"> inside of the <main>, since a card would likely not be the only main content on a page.

  • The alt text should be written naturally, without using - between the words. The alt text must also say where it leads(frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  • I would remove .footnote, as that text is already in the card.

  • .attribution should be a <footer>, and you should use <p> for the text inside.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • I like to add 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

  • On body, remove margin and width - it is a block element, meaning it takes up the full width by default. Change height to min-height - this way, the content will not get cut off if it grows beneath the viewport.

  • Remove all widths and heights.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • Remove font-style: normal, as that is the default value.

  • On the image, add display: block and max-width: 100% - the max-width prevents it from overflowing its container.

  Marked as helpful

  1

  ---

  

  Modupe Marvellous•60

  @Marvie-03Posted 6 months ago

  @Islandstone89 Thanks for this comment, I have implemented every suggestion. And it's better and well constructed.

  1

  

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 6 months ago

  @Marvie-03 well done!

  A few things to notice:

  • Remember to change font-size from px to rem on <p>.

  • Remove max-height on the card.

  • Add min-height: 100svh on body.

  Marked as helpful

  0

  

  Modupe Marvellous•60

  @Marvie-03Posted 6 months ago

  @Islandstone89 Thanks once again! Made the changes you recommended.

  I haven't seen the *svh unit before now, I looked it up .

  1
• 

  P

  JacobKnittle•110

  @JacobKnittlePosted 6 months ago

  Looks good just needs to touching up on the margin and padding specifically with the text.

  0