Skip to content
Submitted about 2 years ago

QR Code Component Solution with CSS Flex

Winnie•40
@Wineshuga
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

This is my very first project here and I am happy I did it. I made use of CSS transform property for the first time to center the element. Sincerely, I do not really know why it had that effect. I'd be happy to get some helpful feedback on that. Thank You :)

Community feedback

  • Lucas 👾•104,400
    @correlucasPosted about 2 years ago

    👾Hi Nweneary, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

    Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:

    1.Use <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

    2.Replace the <h2> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in level of importance, never jump a level.

    3.Don’t use id to give the style of your elements, its not a good idea because id its a too much specific selector used for forms and Javascript code. Instead, use class for styling and let the id for much specific stuff. Its also not advisable to use IDs as CSS selectors because if another element in the page uses the same/similar style, you would have to write the same CSS again. Even if you don't have more than one element with that style right now, it might come later.

    4.The html structure is fine and works, but you can reduce at least 20% of your code cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.

    <body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    1
    Winnie•40
    @WineshugaPosted about 2 years ago

    Wow, this is a wonderful feedback! Thanks Lucas. I really learnt a lot from this. I'll definitely put all these to good use.

    1
    Lucas 👾•104,400
    @correlucasPosted about 2 years ago

    @Whiney96 Hey Nweneary, I'm happy to hear that. Looking forward for your next project.

    0
  • José Manuel Esperanza•220
    @JoseAngaraPosted about 2 years ago

    Hi, when you used left: 50% you moved #main-container 50% length of <body> to the right, so it is not centered because all #main-container is to the right of <body>.

    In order to solve that you used transform: translate(-50%, 0%), it moves #main-container 50% of its width to the right, so now half of it is to the left of <body> and half of it to the right of <body>

    To check more about the positioning properties check here: https://developer.mozilla.org/en-US/docs/Web/CSS/position For translate function check here: https://developer.mozilla.org/en-US/docs/Web/CSS/transform-function/translate

    Also, margin: 0 auto does not work in absolute positioned elements.

    Marked as helpful
    0
    Winnie•40
    @WineshugaPosted about 2 years ago

    @JoseAngara Thank you very much. This made a lot of sense and the resources you shared were very helpful. :)

    0
  • Anita uka•80
    @neetaukaPosted about 2 years ago

    Hello Uzo..Congratulations on your first project and welcome to the community.

    I noticed you used transform property to center your element. Try using body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; } This perfectly centers it.

    Happy coding! ;). I hope to see more of your solutions.

    1
    Winnie•40
    @WineshugaPosted about 2 years ago

    @neetauka Thank you so much. I actually did try to flex the body but it didn't work and that must have been because I didn't add a height as you suggested. I am definitely going to try that out now. Thank you.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord