Skip to content
Submitted about 2 years ago

QR code component solution

Jasham•80
@jasham
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hello Jasham, Congratulations on completing this challenge!

    I saw your solution preview site and I think it's already really good. Here’s some tips for you to improve it:

    It is not advisable to use IDs as CSS selectors because if another element in the page uses the same/similar style, you would have to write the same CSS again. Even if you don't have more than one element with that style right now, it might come later. Something I've noticed in your code is that in many occasions you've added some <div> to wrap contents that don't really need to be inside of a div block. Note that for this challenge all you need is a single block to hold all the content, can be <div> or <main> if you want to use a semantic tag to wrap the content, the cleanest structure for this challenge is made by a block of content with div/main and all the content inside of it (img, h1 and p) without need of any other div or something. See the structure below:

    <body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0
    Jasham•80
    @jashamPosted about 2 years ago

    @correlucas Thanks. I will surely remember this. Your feedback is absolutely helping me Thanks a ton.

    1
  • Travolgi 🍕•31,400
    @denieldenPosted about 2 years ago

    Hi Jasham, congratulations on completing the challenge, great job! 😁

    Also you can use article tag instead of a simple div to the container card for improve the Accessibility

    Hope this help! Happy coding 😉

    Marked as helpful
    0
    Jasham•80
    @jashamPosted about 2 years ago

    @denielden Thanks. I have missed it.

    1
    Travolgi 🍕•31,400
    @denieldenPosted about 2 years ago

    @jasham you are welcome and keep it up :) Good work!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord