QR code component solution using html css

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted almost 3 years ago

  Greeting @dabinderudhan ,

  I have few suggestions regarding your solution:

  • No need to mention image in the alt text as It’s going to be obvious to either a person or a machine when something they're accessing is alt text. Read more how to write an alt text

  • Use min-height: 100vh; instead of height: 100vh /using vh (viewport height) units allows the body to to grow taller if the content outgrows the visible page./

  • width: 350px;an explicit width is not a good way . Remove the width from the main component and change it to max width instead. That will let it shrink a little when it needs to.

  • You should use em and rem units .Both em and rem are flexible, Using px won't allow the user to control the font size based on their needs.Never use px for font size , read more here

  • In this challenge , you don't need media query @media (max-width: 375px) . Even though it is too late to start the mobile layout. Start it as soon as there is room for the layout.

  Last , you can generate another report for your solution after you corrected the accessibility issues.

  Overall , your solution is good. Hopefully this feedback helps.

  0