Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component solution using flexbox

@rodorrego

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Personally, I found the project quite simple. This was a quick code that I made in a few hours, so the responsive section has some details to improve so that it can adapt to many more devices.

Community feedback

@AmrAbdelgwaad

Posted

Hey Romina, Congratulations on completing your first project 🎉

your solution looks nice but there are a couple of things to take into consideration:

  • you shouldn't use divs and use landmarks, wrap your page with <main> tag and the credits should be outside the main tag learn more.

  • <h2> Scan the QR code to visit Frontend Mentor and take your coding skills to the next level </h2> This should be a <p> element not a heading.

  • font sizes should be in ems or rems, not px

  • it will be really useful if you use a modern CSS reset like this one

  • to center a div in the middle of the screen you can use this on its container

.container {
 min-height: 100vh;
   /*using grid*/
 display: grid;
 place-items: center;
   /*using flex*/
   display: flex;
   justify-content: center;
   align-items: center;
}
  • you should avoid using these units vb,vh until it's necessary

  • this project doesn't require media query at all

I hope I don't sound discouraging and happy coding 😁

Marked as helpful

1

@rodorrego

Posted

@AmrAbdelgwaad Thanks for your comments <3 I will be happy to implement your advice in my future projects.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord