@AmrAbdelgwaad
Posted
Hey Romina, Congratulations on completing your first project 🎉
your solution looks nice but there are a couple of things to take into consideration:
-
you shouldn't use divs and use landmarks, wrap your page with <main> tag and the credits should be outside the main tag learn more.
-
<h2> Scan the QR code to visit Frontend Mentor and take your coding skills to the next level </h2>
This should be a <p> element not a heading. -
font sizes should be in ems or rems, not px
-
it will be really useful if you use a modern CSS reset like this one
-
to center a div in the middle of the screen you can use this on its container
.container {
min-height: 100vh;
/*using grid*/
display: grid;
place-items: center;
/*using flex*/
display: flex;
justify-content: center;
align-items: center;
}
-
you should avoid using these units vb,vh until it's necessary
-
this project doesn't require media query at all
I hope I don't sound discouraging and happy coding 😁
Marked as helpful
@rodorrego
Posted
@AmrAbdelgwaad Thanks for your comments <3 I will be happy to implement your advice in my future projects.