QR code component solution using CSS

Community feedback

• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted over 2 years ago

  Hello Yash Goswami ! Congo 👏 on completing this challenge

  Let's look at some of your issues, shall we:

  • Why use <p class="head">Improve your front-end skills by building projects</p> you should use h1 here as it is title of the card

  • the background shadow is very dark so make it more soft

  • Read style-guide and add the font-style and size along with weight

  • Add equal padding or margin for the qr img and the texts

  happy Coding😀

  0

  ---

  

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  @Crazimonk I agree with the first bullet point

  1

  

  Naveen Gumaste•10,480

  @NaveenGumastePosted over 2 years ago

  @TheCoderGuru what about others?

  0

  

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  @Crazimonk I agree with the rest also 🤣

  1

  

  Yash Goswami•70

  @Yash-devaspPosted over 2 years ago

  @Crazimonk thanks for the suggestion I think it will also improve my accessibility issue also. Thanks for your suggestion.

  1
• 

  Abhik•4,840

  @abhik-bPosted over 2 years ago

  👋 Hello Yash ,Congratulations on completing your 1st challenge. Your solution is fantastic & it is very responsive 🤩👌

  Some of my opinions I am sharing with you :

  • give margin: 0; to *{ } to remove unwanted margin from all elements
  • remove the height from card & give gap:1em to make the card look more like the design
  • your box-shadow is very nice

  Very Well Done 🤩 & Please keep coding such amazing solutions 🥳👍

  0

  ---

  

  Yash Goswami•70

  @Yash-devaspPosted over 2 years ago

  @abhik-b Thank you so much for taking the time to go through my code. I will keep in mind your recommendations and improve my code.

  1