QR code component solution using CSS Flex

Community feedback

• Account deleted

  hi @ErenSeven, great work!

  I'm going to give you some suggestions to perfect your code:

  HTML

  • Document should have one main landmark, this should include the main part of your page... you can fix it like this:

  <div class="card">      replace for     <main class="card">
  

  • Page should contain a level-one heading ( a <h1> tag )

  <p class="improve">Improve your front-end skills by building projects</p>
  could you change this <p> tag for a <h1> tag
  

  CSS

  • you are styling an .attribution class that does not exist in your html body, you should delete this code block

  .attribution {font-size: 11px;text-align: center;}
  .attribution a {color: hsl(228, 45%, 44%);}
  

  • even if your style sheet is short like this, it's a bad practice to enclose it between tags. you should create a new css file and call it from the head of your html

  I hope this feedback has been useful to you! keep coding :)

  Marked as helpful

  1