Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component solution

P

@bluethreadmade

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Stefan W. 130

@stewil87

Posted

Hello Megan McNeill! Welcome to FE Mentor, hope to see more of your solutions :) - Overall your solutions is very well readable. (pls be aware, if my answer is some kind of rude, but this is only my second language)

On body you use margin-left and margin-right "auto". It is not needed, when you use flex (with flex direction column) and align-items: center.

You used <b> in the topic <h4>. <b> is only to make something bold, without importance, but it is used in a headline element, so it is important. Also the standard of headline elements are, that they are displayed as bold by default.

Marked as helpful

0

P

@bluethreadmade

Posted

Thank you so much!

And you were certainly not rude.

I didn't know that headline elements were bold by default. And thank you for noting the redundancy of margin left/right: auto with flex align items center.

@stewil87

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord