QR Code Component Solution

Community feedback

• 

  P

  Øystein Håberg•10,390

  @Islandstone89Posted 8 months ago

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify the "main" section of a page. Change .container to a <main>.

  • The alt text must also say where it leads(frontendmentor.io).

  • Never have text in divs alone. "Improve your" is a heading, and "Scan the QR code" is a paragraph. You also don't need to wrap every element in a <div>.

  • .attribution should be a <footer>, and you should use <p> for the text inside.

  CSS:

  • It's good practice to include a CSS Reset at the top.

  • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

  • On the body, change height to min-height - this way, the content will not get cut off if it grows beneath the viewport.

  • Remove font-style: normal - this is the default value.

  • Remove all widths and heights.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

  • On the image, add display: block and max-width: 100% - the max-width prevents it from overflowing its container. Remove object-fit, it is not needed.

  • To create the space between the image and the edge of the card, set padding on all 4 sides of the card.

  Marked as helpful

  1
• 

  Alan Souza•30

  @AlanS3103Posted 8 months ago

  Hey, well done man, I really like your solution, the code looks very well written, keep doing a great job.

  Marked as helpful

  1
• 

  Roraima Lugo González•510

  @roraima1986Posted 8 months ago

  I have no comments to make, the desktop size design is fine and seems to adapt well when it reaches the size of 375px. Of course, below that it does deform a little and for this you can use the half queries.

  Marked as helpful

  1
• 

  P

  Mark Suson•100

  @marksusonPosted 8 months ago

  Looks good. size is off i think. also could be more accessible.

  Marked as helpful

  1