QR Code Component Solution

Community feedback

• 

  P

  Brandon Smith•80

  @brsmit1993Posted 12 months ago

  Overall your code looks pretty clean and well formatted. A few things I noticed though. The first you were mixing px and em and using them interchangeably. Although this isn't a big deal it's usually best to pick one and stick with it throughout your code. The only exception I would say is using 'rem' or 'em' for fonts and then px for everything else. Another note as well I would avoid using 'em' unless you intend to do it for a specific purpose. em values are relative to the font-size of the nearest parent element, while rem values are relative to the root font-size which is generally 16px. I tend to use 'rem' because I know it will always (rem * root font-size) but with em if you've modified font sizes for any of it's parents it can cause weird and unintended effects if not used carefully. Hope this info comes in handy and if you're interested in learning more about rem or em than this article might be a good place.

  https://blog.logrocket.com/using-em-vs-rem-css/

  Marked as helpful

  1

  ---

  

  Yavuz KARAKUŞ•50

  @yavuzkarakusPosted 12 months ago

  Thank you so much for your wonderfully instructive comments. I have reviewed the article you sent and as a result, I will pay attention to my use of px, em and rem in my projects. 🙏🏼🙏🏼 @brsmit1993

  1